Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/apachedruidreceiver] Add Apache Druid receiver #31804

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

yuanlihan
Copy link

Description: The first PR of Apache Druid Receiver as described in issue #29685

Link to tracking Issue: #29685

Testing: This part will be detailed in follow implementation PR.

Documentation: See initial README.

@yuanlihan yuanlihan requested a review from a team as a code owner March 18, 2024 07:29
@yuanlihan yuanlihan requested a review from atoulme March 18, 2024 07:29
Copy link

linux-foundation-easycla bot commented Mar 18, 2024

CLA Missing ID CLA Not Signed

@github-actions github-actions bot added the cmd/otelcontribcol otelcontribcol command label Mar 18, 2024
@atoulme atoulme added the Accepted Component New component has been sponsored label Mar 18, 2024
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add the goleak check for this package? There's a description here on what to do.

receiver/apachedruidreceiver/metadata.yaml Outdated Show resolved Hide resolved
receiver/apachedruidreceiver/metadata.yaml Show resolved Hide resolved
@atoulme
Copy link
Contributor

atoulme commented Mar 22, 2024

confighttp.HTTPServerSettings was just renamed confighttp.ServerConfig, please rebase to latest main and change in your code.

@yuanlihan yuanlihan requested a review from atoulme April 2, 2024 04:34
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Apr 16, 2024
Copy link
Contributor

github-actions bot commented May 1, 2024

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this May 1, 2024
@atoulme atoulme reopened this May 1, 2024
@atoulme atoulme removed the Stale label May 1, 2024
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label May 16, 2024
@atoulme atoulme removed the Stale label May 19, 2024
@atoulme
Copy link
Contributor

atoulme commented May 19, 2024

@yuanlihan please add a changelog?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really sorry about the redirection here, but this file is actually now generated. You can delete this file and then run make generate, and a new file generated_package_test.go will be added instead 👍

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, I'll update them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Component New component has been sponsored cmd/otelcontribcol otelcontribcol command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants